Normalize the package hash to hex. #512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattmoor
force-pushed
the
convert-hash1-to-sha256
branch
from
1d73d0a to
90dd316
Compare
|
So it looks like for whatever reason locally I get: However, in CI we're seeing: Not sure what's going on here, but seems like the cc @imjasonh |
mattmoor
force-pushed
the
convert-hash1-to-sha256
branch
from
1ef43c9 to
90dd316
Compare
We were emitting package checksum hashes as `h1:{base64}`. `h1:` is a prefix that indicates "Hash 1", which is a SHA-256 based hash of the files, which is then base64 encoded as the suffix.
This change detects/strips the `h1:` prefix and re-encodes the base64 data as hex.
mattmoor
force-pushed
the
convert-hash1-to-sha256
branch
from
90dd316 to
149252f
Compare
|
For now I've predicated the |
Codecov Report
@@ Coverage Diff @@
## main #512 +/- ##
==========================================
+ Coverage 50.51% 50.60% +0.09%
==========================================
Files 41 41
Lines 2051 2051
==========================================
+ Hits 1036 1038 +2
+ Misses 840 838 -2
Partials 175 175
Continue to review full report at Codecov.
|
imjasonh
approved these changes
Nov 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were emitting package checksum hashes as
h1:{base64}.h1:is a prefix that indicates "Hash 1", which is a SHA-256 based hash of the files, which is then base64 encoded as the suffix.This change detects/strips the
h1:prefix and re-encodes the base64 data as hex.I also combined the two loops over
.Depssince I noticedbomdoing things in this order. 🤷